Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison link under commits #292

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

killynathan
Copy link
Contributor

@killynathan killynathan commented Sep 4, 2018

If no tags are found, git describe will return an error, causing the program to exit. From my testing and understanding, this wont happen because of

if (!result) {  
  return false;  
}

but I am not completely sure. I would appreciate any feedback.


Fixes #283

@killynathan killynathan changed the title added comparison link under commits (#283) added comparison link under commits (issue #283) Sep 4, 2018
@sindresorhus sindresorhus changed the title added comparison link under commits (issue #283) Add comparison link under commits Nov 29, 2018
@sindresorhus sindresorhus merged commit 3b0ed9a into sindresorhus:master Nov 29, 2018
@sindresorhus
Copy link
Owner

Looks good. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants