Increase util.js test coverage #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xch4z
force-pushed
the
increase-test-coverage-for-util.js
branch
from
0eec968
to
02374c9
Compare
sindresorhus
requested changes
Jun 29, 2019
sindresorhus
changed the title
0xch4z
force-pushed
the
increase-test-coverage-for-util.js
branch
from
03213fb
to
d48293b
Compare
0xch4z
force-pushed
the
increase-test-coverage-for-util.js
branch
from
c56b899
to
da23408
Compare
|
I addressed the feedback and rebased on top of master. Had to add |
sindresorhus
approved these changes
Jun 30, 2019
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #383
This adds additional tests against
source/util.js.