Fix Yarn OTP failure #461
Merged
Fix Yarn OTP failure #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Yarn OTP feature broke after it was added in #302 because, for some reason, the
error.messagestring no longer contains the error message.error.stderrdoes contain it though, so usingerror.stderr.includes('user TTY')would be one solution to fix this problem.However, @sindresorhus was asking about "any better parts of the output we could test" on the original PR. It turns out, Yarn does have this now — it logs the following message when 2FA is enabled:
That's why I decided to use
error.stdout.includes('Two factor authentication')instead.