Conversion of non-promises to promises is problematic for AVA

[jamestalmage]

#1 Causes every argument to be converted to a via Promise.resolve(). That creates a small problem for AVA, since this line expects isPromise(fn) to be false if a function was passed in.

Also, the current behavior creates ambiguity, as:

observableToPromise([1,2]);

Produces an identical result to:

observableToPromise(Observable.of(1,2));

[sindresorhus]

I thought it was a good idea when I merged #1, but I noticed the issue with AVA too a while ago.

Do you have any suggested solution other than reverting?

// @mastilver

[mastilver]

the Promise.resolve is just there if you pass something which is not an observable

We could just check if the arg is not an observable, neither a function

If you are happy with that, I will create a PR in 5-6 hours

[mastilver]

Or we could only support observable and return the passed arg (as it was before my changes)

then you won't be able to do:

observable-to-promise(2).then(x => {
   console.log(x);
   // => 2
});

will throw Uncaught TypeError: then is not a function

[jamestalmage]

My only other thought was to throw a TypeError, if they pass a non observable.

It would require AVA do an is-observable test (so things would be a bit more verbose within AVA). However, I think it's a good change because then this API much more clear.

[mastilver]

throw a TypeError

I'm happy with that

[sindresorhus]

throw a TypeError

👍