Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defineProperty doesn't check for equality #49

Closed
fabiospampinato opened this issue Feb 13, 2020 · 1 comment
Closed

defineProperty doesn't check for equality #49

fabiospampinato opened this issue Feb 13, 2020 · 1 comment

Comments

@fabiospampinato
Copy link

fabiospampinato commented Feb 13, 2020

I think there's a problem here:

const result = Reflect.defineProperty(target, property, descriptor);

Each defineProperty call is basically counted as a change, even if the property descriptor is exactly the same, I think the current and the next descriptor need to be compared before triggering a change.

@DarrenPaulWright
Copy link
Collaborator

Fixed in 1.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants