feat(linux): use system xdg-open when available

[axe312ger]

xdg-open is already available in many desktop linux distributions. This PR changes the code to detect if it is available on the system and uses that one if detected.

This will fix:

• supplied/bundled xdg-open not compatible with your Linux distribution (Did not encouter this yet but could be a potential issue)
• when bundling your app with tools like https://github.com/zeit/pkg, it is not possible to include the xdg-open from this repo in the executable. You need to put the xdg-open file in the same directory as your project/app executable, which I'd like to avoid. Should fix Support pkg #61 for most of the users. (Related: Error with opn vercel/pkg#213)

I am aware that users on linux without xdg-open installed will still have issues, when this lib is bundled via pkg, but I think this risk is acceptable. Especially because when supplying the app via a package manager like apt, a dependency to xdg-utils should do the trick.

What do you think @sindresorhus ?

:)

[sindresorhus]

Many Linux distributions have outdated xdg-open versions missing important bug fixes. Bundling xdg-open have stability and consistency benefits. I want this package to just work out of the box for all Linux users when used with normal Node.js.

supplied/bundled xdg-open not compatible with your Linux distribution (Did not encouter this yet but could be a potential issue)

I'm not going to change anything based on potential issues.

when bundling your app with tools like zeit/pkg, it is not possible to include the xdg-open from this repo in the executable. You need to put the xdg-open file in the same directory as your project/app executable, which I'd like to avoid.

I stand by my comment in #61, I should not have to specially work around random tools. This was already marked as fixed in pkg, but it seems like the fix was not correct and additional comments on vercel/pkg#207 are ignored. Try opening a new issue on pkg about this.

[axe312ger]

Alright. Understandable reasons for you package. Thank you for your quick response.

Just want to point out it is not really a bug in pkg, it is more like a inconvenience / UX problem and not that verbose documentation on pkg side.

Will move the detection into our project to use xdg-open directly when available.

[axe312ger]

We worked around via:

import commandExists from 'command-exists'
import execa from 'execa'
import opn from 'opn'

if (['win32', 'darwin'].includes(process.platform)) {
  await opn(oAuthURL, {
    wait: false
  })
} else {
  try {
    const xdgOpenExists = await commandExists('xdg-open')
    if (!xdgOpenExists) {
      throw new Error('xdg-open does not exist')
    }
    await execa('xdg-open', [oAuthURL])
  } catch (_) {
    log(`Unable to open your browser automatically. Please open the following URI in your browser:\n\n${oAuthURL}\n\n`)
  }
}

[zoutepopcorn]

Thanks @axe312ger

I ve put in on npm https://github.com/zoutepopcorn/opn-pkg

[explosivose]

You can also do something like this as a workaround to point to system's xdg-open

      let opnOpts: {app?: string | string[]};
      if (['win32', 'darwin'].includes(process.platform)) {
        opnOpts = {};
      } else {
        opnOpts = {app: 'xdg-open'};
      }
      return opn(`http://localhost:${port}/client`, opnOpts);