Add option allow positive exit code #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jan 29, 2020
| Type: `boolean`\ | ||
| Default: `true` | ||
|
|
||
| Reject for positive exit code |
There was a problem hiding this comment.
The description needs to be a bit clearer about what it does.
The description should also include use-cases for this option.
|
You need to update index.d.ts too. |
| @@ -102,6 +102,13 @@ We do not recommend using it on targets that are not URLs. | |||
|
|
|||
| Especially useful when dealing with the [double-quotes on Windows](#double-quotes-on-windows) caveat. | |||
|
|
|||
| ##### rejectWithPositive | |||
There was a problem hiding this comment.
I don't think this option name is clear enough.
Maybe allowNonzeroExitCode?
|
// @TanninOne |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #86
I don't know to test with simple exit code so I don't modify
test.js