Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for WSL when Windows isn't mounted in /mnt/ #210

Merged
merged 1 commit into from Jan 7, 2021

Conversation

jonaskuske
Copy link
Contributor

In WSL, Windows drives aren't always mounted in /mnt/ – you can specify the mount location via the root key in wsl.conf. For this reason I replaced the check that verifies the app path starts with /mnt/ with a check that simply looks for / at the start to see if it's a Linux path.

I don't know if the current /mnt/ check was added to handle some specific edge cases, but I think changing it should be ok.

@jonaskuske
Copy link
Contributor Author

I don't know if the current /mnt/ check was added to handle some specific edge cases, but I think changing it should be ok.

Just seen that #210 will add a proper detection for wslAutoMountRoot which we could use for the check, but I think this can be merged already anyway

@sindresorhus sindresorhus changed the title fix: support WSL when Windows isn't mounted in /mnt/ Fix support for WSL when Windows isn't mounted in /mnt/ Jan 7, 2021
@sindresorhus sindresorhus merged commit a3bbadc into sindresorhus:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants