Add newInstance option for macOS
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @sindresorhus for landing edge support. any chance for you to review this? |
sindresorhus
requested changes
May 24, 2021
readme.md
Outdated
|
|
||
| Open a new instance of the application(s) even if one is already running. | ||
|
|
||
| On other platforms, this is always to open a new instance. |
There was a problem hiding this comment.
This needs to be better written.
There was a problem hiding this comment.
Updated to For other platforms, this value is always to be true.
is this better?
sindresorhus
changed the title
newInstance option for macOS
|
updated changes based on your comment, please help to review again. |
|
@sindresorhus Thank you for the great revise and quick review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open command in macOS will try to reuse existing instance by default.
Adding
open -nwill create a new instance no matter if there is existing instance or not.For Windows and Linux, the behavior are to create new instances anyway.
The PR proposes to add a macOS only
newInstanceoption and by default it's false.Not sure if the change making sense or not. feel free to comment for better solution.