Don't allow default as a spinner (#175)

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
sindresorhus · Jun 8, 2021 · 659f839 · 659f839
1 parent c7d6dba
commit 659f839
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -168,7 +168,7 @@ class Ora {
 		} else if (spinner === undefined) {
 			// Set default spinner
 			this._spinner = cliSpinners.dots;
-		} else if (cliSpinners[spinner]) {
+		} else if (spinner !== 'default' && cliSpinners[spinner]) {
 			this._spinner = cliSpinners[spinner];
 		} else {
 			throw new Error(`There is no built-in spinner named '${spinner}'. See https://github.com/sindresorhus/cli-spinners/blob/main/spinners.json for a full list.`);

diff --git a/test.js b/test.js
@@ -322,6 +322,12 @@ if (process.platform !== 'win32') {
 	});
 }
 
+test('throw when spinner is set to `default`', t => {
+	t.throws(() => {
+		new Ora({spinner: 'default'}); // eslint-disable-line no-new
+	}, /no built-in spinner/);
+});
+
 test('indent option', t => {
 	const stream = getPassThroughStream();
 	stream.isTTY = true;