Add link to related module in the readme #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeycozza This is perfect for a terminal stock/crypto exchange ticker 😄 |
|
In the future, please don't uncheck the checkbox that lets maintainers edit your PR. You're just giving them more work then. |
sindresorhus
changed the title
sindresorhus
pushed a commit
that referenced
this pull request
Apr 29, 2018
|
Sorry about that. I wasn't even aware of such a checkbox. Thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I brought up the idea of a marquee spinner which could be generated based off text, instead of someone having to manually write out all the frames they wanted. sindresorhus/cli-spinners#30
The suggestion was to make it its own module, and then it could be linked here in the ora readme.
Please let me know if there are any suggestions or concerns with my module before you'd want to link it in the readme.
Thanks.