Check for optional first before running validator #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
optional
predicate currently has a bug. The bug is that the validator is still executed, even when the value isundefined
. This is wrong off course because in case of this use caseThe predicate will do
undefined.length
which throws aCannot read property 'length' of 'undefined'
(or something).This PR doesn't do that (performance benefit because it doesn't run all the validators) as it first checks if it's
optional
and if thevalue
isundefined
.