-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on try catch block #31
Comments
7ochem
added a commit
to 7ochem/p-limit
that referenced
this issue
Jul 2, 2020
7ochem
added a commit
to 7ochem/p-limit
that referenced
this issue
Jul 2, 2020
7ochem
added a commit
to 7ochem/p-limit
that referenced
this issue
Jul 2, 2020
This package requires Node.js 10: Line 14 in 824edb8
You could downgrade to an older version. |
I have tried this on node 12. Let me check again, just to be sure |
Ok it works in node 10 and 12. Sorry for that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to deploy a function to firebase, and looks like one of the packages I use, uses p-limit, and when trying to deploy the function, in the installation modules package the console gives me the following error:
Detailed stack trace: /srv/node_modules/p-limit/index.js:30
} catch {}
inspecting the p-limit code in my node_modules I see this in line 28
try { await result; } catch {}
there's an error in the catch expression, is missing the parenthesis after catch, catch(error) {}
Firebase functions uses node version 8
https://github.com/sindresorhus/p-limit/blob/master/index.js#L30
The text was updated successfully, but these errors were encountered: