-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lost for Node 16 / CommonJs #63
Comments
Project has became ESM only so we have to stay at 3 major version when using require |
elenatanasoiu
added a commit
to github/vscode-codeql
that referenced
this issue
Oct 12, 2022
Version 4.0 has dropped support for Node 16 / CommonJS so we'd have to first upgrade to ESM before we could use a newer version of this package. This would involve updating package.json with: { "type": "module" } For now let's use the package that just works. We can think of upgrading as a separate issue. See: - sindresorhus/p-limit#63 - https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c - sindresorhus/p-limit#57
elenatanasoiu
added a commit
to github/vscode-codeql
that referenced
this issue
Oct 13, 2022
Version 4.0 has dropped support for Node 16 / CommonJS so we'd have to first upgrade to ESM before we could use a newer version of this package. This would involve updating package.json with: { "type": "module" } For now let's use the package that just works. We can think of upgrading as a separate issue. See: - sindresorhus/p-limit#63 - https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c - sindresorhus/p-limit#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I was running p-limit@3 and tried to upgrade to p-limit@4
Reproduce error
My program is in Typescript and I'm compiling to use CommonJS native (
"module": "commonjs",
in my tsconfig)resulting to an error at runtime
With 3.x
program is working
Is the support lost, or am I using the lib wrongly?
The text was updated successfully, but these errors were encountered: