Throw a useful error if a non-error is thrown

Fixes #14
sindresorhus · Mar 11, 2019 · a9d75a5 · a9d75a5
1 parent 4b6ec19
commit a9d75a5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -39,6 +39,11 @@ const pRetry = (input, options) => new Promise((resolve, reject) => {
 	operation.attempt(attemptNumber => Promise.resolve(attemptNumber)
 		.then(input)
 		.then(resolve, error => {
+			if (!(error instanceof Error)) {
+				reject(new TypeError(`Non-error was thrown: "${error}". You should only throw errors.`));
+				return;
+			}
+
 			if (error instanceof AbortError) {
 				operation.stop();
 				reject(error.originalError);

diff --git a/test.js b/test.js
@@ -151,4 +151,9 @@ test('onFailedAttempt is called before last rejection', async t => {
 		t.is(i, 4);
 		t.is(j, 4);
 	});
+
+test('throws useful error message when non-error is thrown', async t => {
+	await t.throwsAsync(pRetry(() => {
+		throw 'foo'; // eslint-disable-line no-throw-literal
+	}), /Non-error/);
 });