Support getting current Promise queue length #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful in cases e.g. a consuming program wants to check for promise-queue congestion, for reporting on task backlogs.
sindresorhus
requested changes
May 10, 2023
index.js
Outdated
| @@ -92,6 +92,8 @@ export default function pThrottle({limit, interval, strict}) { | |||
|
|
|||
| throttled.isEnabled = true; | |||
|
|
|||
| throttled.queueLength = () => queue.size; | |||
There was a problem hiding this comment.
It should be a getter instead of a function.
queueSize would be a more corrct name.
There was a problem hiding this comment.
Sorry - I might be misunderstanding the comment - I don't believe we can use the get keyword here 'cos we're not in a class / object literal, we're in a function.
Would you mind providing a snippet of what you'd like this changing to and I can get it sorted? Cheers!
(Renamed to queueSize though!)
There was a problem hiding this comment.
Should be sorted in latest commit!
sindresorhus
requested changes
May 11, 2023
|
Thanks :) |
|
Would it make more sense if queueSize was a property of the throttle not the throttled function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful in cases e.g. a consuming program wants to check for promise-queue congestion, for reporting on growing backlogs (e.g. In my case exposing the current promise-queue length as a custom Prometheus metric to alert if the process is seeing latency in churning through what should be a quick-to-process set of queued promises.)