Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing arguments through and require Node.js 6 #2

Merged
merged 3 commits into from
Jun 14, 2018
Merged

Allow passing arguments through and require Node.js 6 #2

merged 3 commits into from
Jun 14, 2018

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Jun 11, 2018

This can be very useful when V8 cannot optimize away the cost of creating a generalized function. Example usage: sindresorhus/p-limit#8

@LinusU
Copy link
Contributor Author

LinusU commented Jun 12, 2018

The ...args syntax doesn't work on Node.js 4.x, but since that is beyond EOL anyhow I thought it was best to drop it. This will have to be a major version bump though.

Updated the Travis config and the engines field in the package.json

@LinusU
Copy link
Contributor Author

LinusU commented Jun 14, 2018

Updated readme per discussion on Slack...

@sindresorhus sindresorhus changed the title Allow passing arguments through Allow passing arguments through and require Node.js 6 Jun 14, 2018
@sindresorhus sindresorhus merged commit d2e5782 into sindresorhus:master Jun 14, 2018
@LinusU LinusU deleted the pass-args branch June 14, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LinusU @sindresorhus