Change regex to support small viewports. For example 50x50 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like http://viewportsizes.com/devices.json is a bit unstable. I need to browse the url first, and then run the tests to get them to pass. |
|
Reran the tests and passes now, so probably just some intermittent issue. |
I think I just assumed no one would use less than that. |
sindresorhus
added a commit
that referenced
this pull request
Mar 19, 2016
Change regex to support small viewports. For example 50x50
|
Using it for screenshot of small banners :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change regex to support small viewports. For example 50x50. Are there any reasons why the range is from 3 to 4?