Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix {secDecimalDigits: 0} rounding rollover issue #27

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Fix {secDecimalDigits: 0} rounding rollover issue #27

merged 2 commits into from
Jul 18, 2018

Conversation

kolyaventuri
Copy link
Contributor

closes #26

  • Adds tests for various off by 1ms differences in the pretty-ms function
  • Uses ms difference to fix the issue before parse, assuming user has set secDecimalDigits to 0

@kolyaventuri kolyaventuri mentioned this pull request Jul 17, 2018
Closed
@sindresorhus sindresorhus changed the title Fixes SecDecmialDigits = 0 rounding rollover issue Fix {secDecimalDigits: 0} rounding rollover issue Jul 18, 2018
@sindresorhus sindresorhus merged commit 7602f88 into sindresorhus:master Jul 18, 2018
@sindresorhus
Copy link
Owner

Looks good. Thanks for fixing, @kolyaventuri :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FireController1847 FireController1847 FireController1847 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SecDecimalDigits Rollover Bug
3 participants
@kolyaventuri @sindresorhus @FireController1847