Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix milliseconds rounding inconsistency #41

Merged
merged 8 commits into from
Feb 12, 2020
Merged

Fix milliseconds rounding inconsistency #41

merged 8 commits into from
Feb 12, 2020

Conversation

explodingcamera
Copy link
Contributor

While everything below 0.1ms keeps the old behavior and gets rounded up to 1ms, everything over that uses Math.round.
Also fixes the issue with 11999 milliseconds rounding to 1m 60s.
Fixes #38

explodingcamera and others added 5 commits October 3, 2019 19:39
Signed-off-by: Henry <mail@henrygressmann.de>
Signed-off-by: Henry <mail@henrygressmann.de>
Signed-off-by: Henry <mail@henrygressmann.de>
Signed-off-by: Henry <mail@henrygressmann.de>
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Fix Rounding inconsistencies Fix milliseconds rounding inconsistency Nov 13, 2019
@villebro
Copy link
Contributor

@explodingcamera are you planning on implementing the requested changes? If not, I don't mind implementing the fix.

Signed-off-by: Henry Gressmann <mail@henrygressmann.de>
Signed-off-by: Henry Gressmann <mail@henrygressmann.de>
@sindresorhus sindresorhus merged commit f48b81c into sindresorhus:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding inconsistency
3 participants