New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use one ps
execution instead of multiple when possible
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jun 10, 2019
Can you give the PR a proper title? |
stroncium
changed the title
fix #14
Use one Jun 14, 2019
ps
execution instead of multiple when possible, fixes #14
sindresorhus
changed the title
Use one
Use one Jun 15, 2019
ps
execution instead of multiple when possible, fixes #14ps
execution instead of multiple when possible
sindresorhus
requested changes
Jun 15, 2019
Would be good to maybe add some more tests. |
@sindresorhus It's quite hard to test it for good, but I've added one more test where most parameters(except mem and cpu) are controlled. |
Closed
@stroncium I upgraded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so I examined all
ps
implementations I found and it turns out they have one thing in common: they print comm and args values(doesn't apply to headers) left aligned.Using this and the fact we run
ps
itself with controlled arguments, we parseps
output, find the line withps
itself, find out locations of comm and args and length of comm and use this info to parse all the lines. Afterwards, we excludeps
itself from resulting process list(which was a side-effect of previous implementation and probably is the right thing to do anyway).Fixes #14