Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process name test #45

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Add process name test #45

merged 3 commits into from
Oct 4, 2020

Conversation

yaodingyd
Copy link
Contributor

@yaodingyd yaodingyd commented Jul 13, 2020 •
edited

sindresorhus/fkill#38 (comment)

ps-list gives different output of process.name on linux node 12.18 from other platforms

@yaodingyd yaodingyd mentioned this pull request Jul 16, 2020
Merged
@sindresorhus
Copy link
Owner

ps-list gives different output of process.name on linux node 12.18 from other platforms

Can you look into why that is? Maybe it's a Node.js bug?

@sindresorhus
Copy link
Owner

At minimum, the test should be marked as test.failing on Linux.

@yaodingyd
Copy link
Contributor Author

I created this nodejs/node#35503 in node

@sindresorhus sindresorhus changed the title add process name test Add process name test Oct 4, 2020
@sindresorhus sindresorhus merged commit cd12fad into sindresorhus:master Oct 4, 2020
@yaodingyd yaodingyd deleted the test branch October 5, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaodingyd @sindresorhus