Use the promise version of execFile
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| } | ||
| }); | ||
| }); | ||
| const {stdout, psPid} = await execFile('ps', [flags, psFields], {maxBuffer: TEN_MEGABYTES}); |
There was a problem hiding this comment.
I don't think this is correct. Where is the pdPid property coming from?
There was a problem hiding this comment.
You're right, I am not sure why the tests passed anyway. Can you take a look at my most recent tweak? Should work now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the sync method of execFile which results in a blockage of the main thread is no longer necessary because the upstream issue that introduced this has been fixed nodejs/node#28325