New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request | arrow prompt ❯ color #303
Comments
For this to happen, the only change required is to replace
Magenta and red are not good combinations as on some color schemes it is a bit difficult to tell them apart. Green and red should be easy to spot. |
I don't want a green prompt character. That looks boring. How about we instead change the error color to yellow? |
Changing the error color to yellow is fine with me. |
@sindresorhus @fazlearefin Yes, I agree as well on yellow. That is a biggest enough difference imo |
I can make the change and raise a pull request if that helps get this change to the repo quicker. |
I'm not a fan to switching the color to yellow, too close to green (== OK). And it does look quite out of place. Thoughts on #306? |
What about using options for the two colors in
|
@will-stone this is being considered, I think both me and @sindresorhus agree that we don't want new environment variables for configuring this, though. So using This feature has been quite low-prio for me personally, so if anyone is interested to help, a proposal / PR is definitely welcomed. To start with, I think it makes sense to limit this to colorizing the prompt character only, in the future more colors customizations could be introduced, but let's see how it works first. |
I'll raise a PR if I get some time and manage to get it to work as proposed in #306 . |
How's this going? |
I hope it's still going. It's very hard for my eyes to differentiate between the default color (magenta-ish) and the error color (red), considering the prompt character is really thin/small. |
@craftyguy +1 same here |
The arrow prompt
❯
color for normal ($? -eq 0
) and not normal ($? -ne 0
) is not very obvious. I suggest you use grey or green for the arrow prompt when normal ($? -eq 0
).The text was updated successfully, but these errors were encountered: