Add support for configuring colors with zstyle #472

bricewge · 2019-05-05T12:21:20Z

Following the discussion at #306 this PR add the capacity to change the colors of pure by using zstyle to avoid polluting the global name space.

Available colors:

branch
error
exec_time
git_arrow
host
path
root
success
user
virtualenv

Fixes #126
Fixes #303
Fixes #306
Fixes #389
Closes #256
Closes #450

EDIT: Add requested colors.

eladchen · 2019-05-14T11:54:15Z

Any chance this will be merged soon?

pure.zsh

readme.md

mafredri

Thanks for your work on this @bricewge, much appreciated!

pure.zsh

readme.md

pure.zsh

readme.md

pure.zsh

bricewge · 2019-06-12T20:08:33Z

The updated PR add branch:cached color. allow live updating of all the colors and show how to 2 state colors at one.
@mafredri @sindresorhus Can I get a second round of review?

mafredri

Thanks, this is shaping up nicely!

There were a few quirks with zstyle that caught my eye, but in general I'm liking the look of this.

pure.zsh

readme.md

LitoMore · 2019-06-13T11:46:51Z

Can you fix the merge conflict?

bricewge · 2019-06-13T12:06:18Z

@LitoMore Thanks for the heads-up, I forgot that your PR got merged.

Available colors: - exec_time - git:arrow - git:branch - git:branch:cached - host - path - prompt:error - prompt:success - user - user:root, default color changed from `white` to `default` - virtualenv

mafredri

Aww yeah 😎! LGTM!

Did a quick trial run, tweaking the colors is pretty fun.

zstyle :prompt:pure:exec_time color 225
zstyle :prompt:pure:git:arrow color 220
zstyle :prompt:pure:git:branch color 106
zstyle :prompt:pure:host color 30
zstyle :prompt:pure:path color 230
zstyle :prompt:pure:prompt:error color 196
zstyle :prompt:pure:prompt:success color 222
zstyle :prompt:pure:user color 36

sindresorhus · 2019-06-17T07:02:14Z

I think this should be documented #472 (comment) as being possible.

readme.md

bricewge

I think this should be documented #472 (comment) as being possible.

What do you mean? If it's deleting a style, I don't think it's necessary because zstyle use the most specific and latest zstyle when queried and it will only make sense when testing. Or do you mean that when a style is deleted it return to it's default value which I also don't think is needed to be specified since it follow the principle of least astonishment.

zstyle usage is best left to the manual because of all it's quirk, even @mafredri already fell into on of it's pothole #472 (comment).

readme.md

sindresorhus · 2019-06-17T14:46:40Z

readme.md

+As explained in ZSH's[manual](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting) color values can be:
+- a decimal integer up to the maximal number of color your terminal support
+- the name of one of the following nine colours: `black`, `red`, `green`, `yellow`, `blue`, `magenta`, `cyan`, `white` and `default` (the terminal’s default foreground)
+- ‘#’ followed by an RGB triplet in hexadecimal format (ex. `#424242`), *only* if your terminal support 24bit colors or when the module [`zsh/nearcolor`](http://zsh.sourceforge.net/Doc/Release/Zsh-Modules.html#The-zsh_002fnearcolor-Module) is loaded


We should show an example of loading zsh/nearcolor and using a HEX color in the Example section. I think a lot of users will want this.

sindresorhus · 2019-06-17T14:48:07Z

readme.md

@@ -96,6 +96,11 @@ prompt pure

 ## Colors

+As explained in ZSH's[manual](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting) color values can be:
+- a decimal integer up to the maximal number of color your terminal support


What does the decimal integer represent? How can users find the number they want? Those are some questions we should answer.

In general, we should not force users to read the horrible ZSH manual to achieve things most user would want.

I have explained what it represent but the way to find the which color that I can't explain because it is terminal specific.

Now I understand the reason behind all your comments on the documentation side. And I'm happy to see I'm not the only one thinking that this manual isn't well written! Hell I have even found this gem in the manual:

[...] the Zsh Development Group accepts no responsibility for any brain damage which may occur during the reading [...]

bricewge

Is it good this time?

bricewge · 2019-06-17T15:06:18Z

readme.md

@@ -96,6 +96,11 @@ prompt pure

 ## Colors

+As explained in ZSH's[manual](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting) color values can be:
+- a decimal integer up to the maximal number of color your terminal support


I have explained what it represent but the way to find the which color that I can't explain because it is terminal specific.

Now I understand the reason behind all your comments on the documentation side. And I'm happy to see I'm not the only one thinking that this manual isn't well written! Hell I have even found this gem in the manual:

[...] the Zsh Development Group accepts no responsibility for any brain damage which may occur during the reading [...]

bricewge · 2019-06-17T15:45:57Z

readme.md

+As explained in ZSH's[manual](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting) color values can be:
+- a decimal integer up to the maximal number of color your terminal support
+- the name of one of the following nine colours: `black`, `red`, `green`, `yellow`, `blue`, `magenta`, `cyan`, `white` and `default` (the terminal’s default foreground)
+- ‘#’ followed by an RGB triplet in hexadecimal format (ex. `#424242`), *only* if your terminal support 24bit colors or when the module [`zsh/nearcolor`](http://zsh.sourceforge.net/Doc/Release/Zsh-Modules.html#The-zsh_002fnearcolor-Module) is loaded


readme.md

pure.zsh

sindresorhus · 2019-06-20T05:19:26Z

This looks good to me now. @bricewge, Thanks for contributing 🙌

sindresorhus · 2019-06-20T15:28:25Z

It's out now: https://twitter.com/sindresorhus/status/1141729038068641797 🎉

dcastil · 2019-06-20T18:38:33Z

Huge thanks for this! Huge win for accessibility for prompt:success / prompt:error! 😊

jonmorton · 2019-06-24T21:17:55Z

@bricewge Is zsh 5.2 a new enough version for this change? I started getting prompt_pure_setup:43: bad set of key/value pairs for associative array' with this update and pure no longer works.

jonmorton · 2019-06-24T21:34:40Z

I can confirm that reverting this diff fixes pure on zsh 5.2. I think it'd be good to make pure work for this version because it is the current stable one used by CentOS.

mafredri · 2019-06-25T08:56:15Z

@jonmorton 5.2 is supported, this was a regression. Thanks for reporting, it's fixed in 1.10.2. Btw, I even use Pure on 4.3.17 or 5.0.2, occasionally 😛.

Btw, next time please open up a new issue as it helps with tracking 😄.

* upstream/master: (25 commits) Fix incorrect color name in the readme (sindresorhus#482) 1.10.3 Fix username prompt expansion 1.10.2 Bump version number in pure state Fix bad set of key/value pairs on old versions of ZSH 1.10.1 Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479) 1.10.0 Update the zsh-async version to reflect the code Improve code comments Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477) Add support for configuring colors with zstyle (sindresorhus#472) Improve the style of the continuation prompt (PS2) (sindresorhus#323) Fix username color (sindresorhus#450) Add `prompt_pure_system_report` for reporting issues (sindresorhus#468) Add pure10k to the list of ports (sindresorhus#474) Create funding.yml Add pure-pwsh to the ports section of the readme (sindresorhus#467) Skip grep fork, use native zsh matching (sindresorhus#459) ...

* upstream/master: Fix incorrect color name in the readme (sindresorhus#482) 1.10.3 Fix username prompt expansion 1.10.2 Bump version number in pure state Fix bad set of key/value pairs on old versions of ZSH 1.10.1 Suppress warning of WARN_CREATE_GLOBAL option (sindresorhus#479) 1.10.0 Update the zsh-async version to reflect the code Improve code comments Avoid performing prompt reset in zle-line-finish hook (sindresorhus#477) Add support for configuring colors with zstyle (sindresorhus#472) Improve the style of the continuation prompt (PS2) (sindresorhus#323) Fix username color (sindresorhus#450) Add `prompt_pure_system_report` for reporting issues (sindresorhus#468) Add pure10k to the list of ports (sindresorhus#474) Create funding.yml # Conflicts: # package.json # pure.zsh # readme.md

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

bricewge force-pushed the zstyle-colors branch from 18cd638 to 885de0c Compare May 5, 2019 12:27

cole-h reviewed Jun 3, 2019

View reviewed changes

pure.zsh Outdated Show resolved Hide resolved

cole-h reviewed Jun 3, 2019

View reviewed changes

pure.zsh Outdated Show resolved Hide resolved

bricewge force-pushed the zstyle-colors branch 3 times, most recently from c210cee to 044b21c Compare June 3, 2019 12:00

cole-h reviewed Jun 3, 2019

View reviewed changes

pure.zsh Outdated Show resolved Hide resolved

sindresorhus changed the title ~~configure colors with zstyle~~ Add support for configuring colors with zstyle Jun 10, 2019

sindresorhus requested changes Jun 10, 2019

View reviewed changes

readme.md Outdated Show resolved Hide resolved

bricewge force-pushed the zstyle-colors branch 2 times, most recently from 103e822 to 202b97f Compare June 10, 2019 20:17

This was referenced Jun 11, 2019

Add support for custom prompt arrow color #256

Closed

Allow setting pre-prompt by user ENV var #464

Closed

mafredri reviewed Jun 11, 2019

View reviewed changes

pure.zsh Outdated Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

pure.zsh Outdated Show resolved Hide resolved

pure.zsh Outdated Show resolved Hide resolved

readme.md Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

LitoMore suggested changes Jun 11, 2019

View reviewed changes

pure.zsh Outdated Show resolved Hide resolved

LitoMore mentioned this pull request Jun 11, 2019

Fix username color #450

Merged

bricewge force-pushed the zstyle-colors branch 3 times, most recently from 6570bea to 3f018b0 Compare June 12, 2019 20:03

mafredri requested changes Jun 12, 2019

View reviewed changes

pure.zsh Outdated Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

bricewge force-pushed the zstyle-colors branch from 3f018b0 to cc3e132 Compare June 13, 2019 11:10

bricewge force-pushed the zstyle-colors branch from cc3e132 to fcb7fa1 Compare June 13, 2019 12:04

configure colors with zstyle

fc462c4

Available colors: - exec_time - git:arrow - git:branch - git:branch:cached - host - path - prompt:error - prompt:success - user - user:root, default color changed from `white` to `default` - virtualenv

bricewge force-pushed the zstyle-colors branch from fcb7fa1 to fc462c4 Compare June 13, 2019 13:33

mafredri approved these changes Jun 13, 2019

View reviewed changes

Update readme.md

842b26c

sindresorhus reviewed Jun 17, 2019

View reviewed changes

readme.md Outdated Show resolved Hide resolved

bricewge commented Jun 17, 2019

View reviewed changes

readme.md Outdated Show resolved Hide resolved

readme.md Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

sindresorhus reviewed Jun 17, 2019

View reviewed changes

bricewge commented Jun 17, 2019

View reviewed changes

bricewge force-pushed the zstyle-colors branch from 6846e18 to 8c2cb93 Compare June 17, 2019 15:48

LitoMore suggested changes Jun 18, 2019

View reviewed changes

readme.md Outdated Show resolved Hide resolved

fixup! configure colors with zstyle

9936741

bricewge force-pushed the zstyle-colors branch from 8c2cb93 to 9936741 Compare June 18, 2019 08:40

sindresorhus added 3 commits June 20, 2019 00:53

Update readme.md

c5c0884

Update pure.zsh

82679b2

Update readme.md

8531651

sindresorhus approved these changes Jun 19, 2019

View reviewed changes

pure.zsh Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

fixup! configure colors with zstyle

7227b99

This comment has been minimized.

Sign in to view

sindresorhus merged commit be099f2 into sindresorhus:master Jun 20, 2019

star-szr mentioned this pull request Jun 27, 2019

Fix incorrect color name in the readme #482

Merged

kutsan pushed a commit to kutsan/pure that referenced this pull request Jun 19, 2023

Add support for configuring colors with zstyle (sindresorhus#472)

98ad3a5

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for configuring colors with zstyle #472

Add support for configuring colors with zstyle #472

bricewge commented May 5, 2019 •

edited by sindresorhus

Loading

eladchen commented May 14, 2019

mafredri left a comment

bricewge commented Jun 12, 2019

mafredri left a comment

LitoMore commented Jun 13, 2019

bricewge commented Jun 13, 2019

mafredri left a comment

sindresorhus commented Jun 17, 2019

bricewge left a comment

sindresorhus Jun 17, 2019

bricewge Jun 17, 2019

sindresorhus Jun 17, 2019

bricewge Jun 17, 2019

bricewge left a comment •

edited

Loading

bricewge Jun 17, 2019

bricewge Jun 17, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sindresorhus commented Jun 20, 2019

sindresorhus commented Jun 20, 2019

dcastil commented Jun 20, 2019

jonmorton commented Jun 24, 2019 •

edited

Loading

jonmorton commented Jun 24, 2019

mafredri commented Jun 25, 2019

Add support for configuring colors with zstyle #472

Add support for configuring colors with zstyle #472

Conversation

bricewge commented May 5, 2019 • edited by sindresorhus Loading

eladchen commented May 14, 2019

mafredri left a comment

Choose a reason for hiding this comment

bricewge commented Jun 12, 2019

mafredri left a comment

Choose a reason for hiding this comment

LitoMore commented Jun 13, 2019

bricewge commented Jun 13, 2019

mafredri left a comment

Choose a reason for hiding this comment

sindresorhus commented Jun 17, 2019

bricewge left a comment

Choose a reason for hiding this comment

sindresorhus Jun 17, 2019

Choose a reason for hiding this comment

bricewge Jun 17, 2019

Choose a reason for hiding this comment

sindresorhus Jun 17, 2019

Choose a reason for hiding this comment

bricewge Jun 17, 2019

Choose a reason for hiding this comment

bricewge left a comment • edited Loading

Choose a reason for hiding this comment

bricewge Jun 17, 2019

Choose a reason for hiding this comment

bricewge Jun 17, 2019

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sindresorhus commented Jun 20, 2019

sindresorhus commented Jun 20, 2019

dcastil commented Jun 20, 2019

jonmorton commented Jun 24, 2019 • edited Loading

jonmorton commented Jun 24, 2019

mafredri commented Jun 25, 2019

bricewge commented May 5, 2019 •

edited by sindresorhus

Loading

bricewge left a comment •

edited

Loading

jonmorton commented Jun 24, 2019 •

edited

Loading