Make sure GPG-agent does not mess up the tty #645
Conversation
When gpg-agent is used as an ssh-agent and configured with pinentry-ncurses, it messes up the terminal immediately after you cd into a git repository with an ssh remote.
sheeviZi
force-pushed
the
gpg-agent-fix
branch
from
dc6e572
to
946634b
Compare
|
@sheeviZi that looks very simple, but what is the intended effect of this change?
Sorry I spoke too fast. Looks like my gpg-agent wasn't set up properly while I was trying to reproduce. See review comment. |
…er arrives Pipe /dev/null to stdin of the worker zpty to prevent child processes from waiting for input.
|
@antoineco Thanks for your time. |
|
@sheeviZi a note about the bounty on this issue. If you want to claim the reward, you will have to
|
|
@sheeviZi I saw the request for review but I am only providing feedback as a user, not a maintainer. You will have to wait for a maintainer to get their eyes on this in order to have it merged (if accepted as a solution to the problem). |
|
@antoineco Are you ok with the wiki page? |
|
Yes I think that looks good, and it's useful information paired with the fix from this PR. |
|
@mafredri is this ok for merge? |
|
@sindresorhus can you please take a look in order to close the linked issue; Otherwise I am not able to claim the bounty on issuehunt. |
|
Thank you @sindresorhus for merging this PR. Just mention me with @sheeviZi if you need anything in the future. |
When gpg-agent is used as an ssh-agent and configured with pinentry-ncurses,
it messes up the terminal immediately after you cd into a git repository with an ssh remote.
Fixes #366.
I can help you reproduce it if you ask.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: