Remove ampersand

[saromanov]

Hi!
If query string starts with &, result from parse will be { '': null, data: 'item' }

console.log(query.parse("&data=item")); //{ '': null, data: 'item' }

So, I've just a made more predictable behavior.

console.log(query.parse("&data=item")); //{ data: 'item' }

[sindresorhus]

That's a invalid query string. The ampersand & is a separator. Why do you need this?

[sindresorhus]

Should implemented on line 8.

[sindresorhus]

@saromanov ⬆️

[saromanov]

This is remove only from start of the string. Not from all of this. For example:

console.log(query.parse("&data=foo&data=bar&fun=bag)); //{ data: [ 'foo', 'bar' ], fun: 'bag' }

[sindresorhus]

No, I mean, why does your querystring start with a &? As I said, that's invalid, some I'm curious why it's like that.

[saromanov]

Yes, i know that this is invalid, but my main motivation was replace incorrect behavior(in my point of view) with ampersand. In other cases, even if you put something incorrect, your response will be also invalid

console.log(query.parse("/data=foo"));  //{ '/data': 'foo' }
console.log(query.parse("*data=foo"));  //{ '*data': 'foo' }

No problems. But with the ampersand case, you'll get:

console.log(query.parse("&data=foo")); //{ '': null, data: 'foo' }

And i decided to make "clear" response {data: 'foo'} without {'': null}.

[sindresorhus]

Alright, I guess it wouldn't hurt. Just fix the inline comments and I'll merge.

[saromanov]

Fixed!

[arthurvr]

triple equal

[saromanov]

Thanks, @arthurvr! Fixed, again.

[sindresorhus]

@saromanov ➡️ #23 (comment)

[saromanov]

@sindresorhus , sorry, i not have much experience with github pull requests and i don't know what to do next. I was fixed with your comments(move to the right lines), but should i open new pull request? Or commit it again?

[sindresorhus]

Sorry if I weren't clear. The & should be stripped here https://github.com/sindresorhus/query-string/pull/23/files#diff-168726dbe96b3ce427e7fedce31bb0bcR12 as we already strip # and ? there.

[saromanov]

Now, its clear for me :)

[sindresorhus]

Looks good. Thanks :)

[tmedetbekov]

It is simpler and faster to use a regex /^[?#&]/ instead

[sindresorhus]

I doubt it has any practical performance difference, but it is indeed simpler. Thanks :)

f283341