Support custom array separator #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for stringify too? |
sindresorhus
requested changes
Jan 16, 2020
|
I think we should validate the option. That the given string is exactly one character. And throw a TypeError if not. |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
|
Don't forget to keep the readme and TS file in sync. |
|
@sindresorhus I made the requested changes. |
|
@sindresorhus just a follow up for a review of changes |
Merged
18 tasks
sindresorhus
changed the title
|
Can you fix the merge conflict? |
|
Conflicts resolved. |
|
Thanks :) |
This was referenced Apr 23, 2020
This was referenced May 2, 2020
This was referenced May 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #226