Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use more stringent version of encodeURIComponent #29

Closed
wants to merge 1 commit into from

Conversation

go-oleg
Copy link
Contributor

@go-oleg go-oleg commented Jul 21, 2015

No description provided.

@kevva
Copy link
Contributor

kevva commented Jul 21, 2015

@sindresorhus
Copy link
Owner

Why is this needed though? What makes the builtin method not good enough?

@go-oleg
Copy link
Contributor Author

go-oleg commented Jul 21, 2015

My specific issue is that Confluence will truncate the "link" of a pasted URL at the first '...so they must be following stricter rules w.r.t. what is and isn't a valid URL character. At first I thought it was a Confluence bug, but seeing the snippet on MDN it makes more sense. Perhaps there are other products that share this behavior out there.

@sindresorhus
Copy link
Owner

Ok, sure. I guess it doesn't hurt to be stricter. Will merge when you've changed it to use https://github.com/kevva/strict-uri-encode ;)

@go-oleg
Copy link
Contributor Author

go-oleg commented Jul 24, 2015

@sindresorhus, done ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants