New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove handling of iterables, only allow arrays as input #2

Merged

sindresorhus merged 1 commit into sindresorhus:master from BendingBender:remove-iterable-handling

Apr 17, 2019

Contributor

BendingBender commented Apr 12, 2019

No description provided.


          Remove handling of iterables, only allow arrays as input

c0deb17

sindresorhus merged commit deff795 into sindresorhus:master

goto-bus-stop pushed a commit to goto-bus-stop/wikibattle that referenced this pull request


          Update random-item to the latest version 🚀 (#80)

e4c91c2

## The dependency [random-item](https://github.com/sindresorhus/random-item) was updated from `2.0.0` to `3.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v3.0.0</summary>

<p>Breaking:</p>
<ul>
<li>Remove handling of iterables, only allow arrays as input (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432762066" data-permission-text="Issue title is private" data-url="sindresorhus/random-item#2" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/random-item/pull/2/hovercard" href="https://urls.greenkeeper.io/sindresorhus/random-item/pull/2">#2</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/random-item/commit/deff79576b56334da132bb8a4b4294c77e8ffcf4/hovercard" href="https://urls.greenkeeper.io/sindresorhus/random-item/commit/deff79576b56334da132bb8a4b4294c77e8ffcf4"><tt>deff795</tt></a><br>
<em>It doesn't make sense to accept iterables when we don't take advantage of it internally. Users can just instead use <code>...iterable</code> which turns it into an array that the module accepts.</em></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/random-item/compare/v2.0.0...v3.0.0"><tt>v2.0.0...v3.0.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 3 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/random-item/commit/bfd099447e34c1545a6895991504b8b37203a1ef"><code>bfd0994</code></a> <code>3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/random-item/commit/c0e9faaa49154730e12745f3ab0541e26926291f"><code>c0e9faa</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/random-item/commit/deff79576b56334da132bb8a4b4294c77e8ffcf4"><code>deff795</code></a> <code>Remove handling of iterables, only allow arrays as input (#2)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/random-item/compare/9f001f8bec1d369dfefe66ad273ca32b821e101c...bfd099447e34c1545a6895991504b8b37203a1ef">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴

erezrokah mentioned this pull request

chore(deps): remove dependency random-item netlify/cli#2394

Closed

Contributor

UltiRequiem commented Apr 3, 2022 •

edited

Loading

May ask why the handling of iterable was removed?

EDIT: Nevermind, just saw the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment