Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should check if file is a directory rather than basename(fp) === 'package.json' #2

Closed
stevemao opened this issue Sep 3, 2015 · 2 comments
Closed

Should check if file is a directory rather than basename(fp) === 'package.json' #2

stevemao opened this issue Sep 3, 2015 · 2 comments

Comments

@stevemao
Copy link
Contributor

stevemao commented Sep 3, 2015

https://github.com/sindresorhus/read-pkg/blob/master/index.js#L13
If it's not a directory we shouldn't then append 'package.json'.
Mainly for tests https://github.com/npm/normalize-package-data/tree/master/test/fixtures. I have a bunch of package.jsons that are called something else.
@sindresorhus
Copy link
Owner

Sure, wanna do a PR?

@stevemao
Copy link
Contributor Author

stevemao commented Sep 3, 2015

Yup :)

@stevemao stevemao mentioned this issue Sep 3, 2015
Closed
stevemao added a commit to stevemao/read-pkg that referenced this issue Sep 5, 2015
@stevemao
Use pathType.dir to detect if path is directory rather than checking …
815c58f 
…the basename

Closes sindresorhus#2
stevemao added a commit to stevemao/read-pkg that referenced this issue Sep 5, 2015
@stevemao
Detect if path is actually a directory
57f5329 
Closes sindresorhus#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @stevemao