Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm dialog before closing the window if unsaved changes #1037

Closed
lex111 opened this issue Jan 25, 2018 · 2 comments
Closed

Confirm dialog before closing the window if unsaved changes #1037

lex111 opened this issue Jan 25, 2018 · 2 comments
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@lex111
Copy link

lex111 commented Jan 25, 2018

Yeah, I noticed that the entered data is saved, and when page (issue, eg) are reopened they are inserted into the input fields, it's good if there is a sudden light outage, for example. But if I have many many tabs and write a comment in the issue and accidentally close it (:man_facepalming:), then it would be nice if the confirm dialog was displayed before the page was closed so that this one would not close. How do you like this idea?

@fregante fregante added enhancement help wanted under discussion small Issues that new contributors can pick up labels Jan 26, 2018
@fregante
Copy link
Member

It's nice in theory, but probably annoying in practice.

GH does save comments... except inline comments, so this feature would also save those.

I wouldn't mind giving it a try, if you're willing to implement it.

@fregante
Copy link
Member

fregante commented Sep 7, 2019

I think this can be replaced by #1598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

No branches or pull requests

2 participants