Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pressing arrow-up when choosing labels #1450

Closed
krzysztof-grzybek opened this issue Jul 29, 2018 · 6 comments · Fixed by #2140
Closed

Support pressing arrow-up when choosing labels #1450

krzysztof-grzybek opened this issue Jul 29, 2018 · 6 comments · Fixed by #2140

Comments

@krzysztof-grzybek
Copy link

krzysztof-grzybek commented Jul 29, 2018

Issuehunt badges

It's new feature proposal.

Scenario:
I created pull request, and I'm adding labels. I want to add label Please CR: JS. I type first two letters (Pl) into search input, and now I see 5 similar labels (e.g. Please CR: CSS, Please CR: HTML). The one that I'm looking for is at the very end. I'd like to navigate to this label by pressing up arrow. Unfortunately, nothing happens.

Feature proposal:
During label searching, pressing up arrow at first item navigates me to the last one, and pressing down arrow at last item navigates me to the first item.


IssueHunt Summary

[
<
i
m
g

s
r
c

'
h
t
t
p
s
:
/
/
a
v
a
t
a
r
s
0
.
g
i
t
h
u
b
u
s
e
r
c
o
n
t
e
n
t
.
c
o
m
/
u
/
3
7
7
6
9
9
7
4
?
v

4
'

a
l
t

'
n
o
t
l
m
n
'

w
i
d
t
h

2
4

h
e
i
g
h
t

2
4

n
o
t
l
m
n
]
(
h
t
t
p
s
:
/
/
i
s
s
u
e
h
u
n
t
.
i
o
/
u
/
n
o
t
l
m
n
)

h
a
s

b
e
e
n

r
e
w
a
r
d
e
d
.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Member

👍 Sounds useful.

Make sure you also send this feature request to GitHub: support@github.com

@sindresorhus sindresorhus changed the title Support for arrow up during label choosing. Support pressing arrow-up when choosing labels Jul 30, 2018
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@janat08
Copy link
Contributor

janat08 commented Apr 15, 2019

The current code (from prs) tries to apply this behaviour to all menus (like authors, etc.), and they have different classes. It's currently failing to apply the behaviour when youre in issue/pr, and when if you've selected such from the list. Within the issue/pr it applies an additional class.

The last pr said github doing it, and then appears to have recanted.

@janat08
Copy link
Contributor

janat08 commented Apr 22, 2019

Some of these sidebar menus mysteriously can't be selected #977

@janat08
Copy link
Contributor

janat08 commented Apr 22, 2019

Might be worthwhile checking if they could be once menu is opened.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 24, 2019

@sindresorhus has rewarded $36.00 to @notlmn. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment