Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line-through on deleted branches in PRs #2274

Closed
rahgurung opened this issue Jul 27, 2019 · 4 comments · Fixed by #2847
Closed

Add line-through on deleted branches in PRs #2274

rahgurung opened this issue Jul 27, 2019 · 4 comments · Fixed by #2847
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@rahgurung
Copy link
Contributor

rahgurung commented Jul 27, 2019

Only colon is line-throughed here.
Screenshot from 2019-07-27 13-21-33

Link to PR in screenshot: #2233

@rahgurung rahgurung added the bug label Jul 27, 2019
@fregante
Copy link
Member

Thanks for the report!

It’s a duplicate of #1985

I hope someone sends a PR soon ☺️

@fregante
Copy link
Member

fregante commented Jul 29, 2019

Reopening because now this needs to be re-implemented as its own feature: cross-deleted-pr-branches

Most of the logic is in cb8de12 (removed) but now we only need to use the part that adds the strike-through, not the linkifier.

The feature could also point the link to the repo root (instead of the 404 deleted branch) to make it somewhat useful.

@fregante fregante changed the title text-decoration: line-through; not working for deleted branches. Add line-through on deleted branches in PRs Jul 29, 2019
@fregante fregante added small Issues that new contributors can pick up help wanted enhancement and removed bug labels Jul 29, 2019
@rahgurung
Copy link
Contributor Author

The feature could also point the link to the repo root (instead of the 404 deleted branch) to make it somewhat useful.

Forked repo root or the primary repo?

@fregante
Copy link
Member

fregante commented Aug 5, 2019

The head branch could either be from the same repo or from a fork. I think it would only make sense to point to the fork’s default branch and do nothing if it’s the same repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
2 participants