Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature linkify-branch-refs #1985

Closed
fregante opened this issue Apr 25, 2019 · 6 comments
Closed

Update feature linkify-branch-refs #1985

fregante opened this issue Apr 25, 2019 · 6 comments
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

It's been added by GitHub, however their version doesn't add a strike-through to deleted branches. Perhaps the feature should just add a strike-through.

Testing threads:
fregante added a commit that referenced this issue Apr 25, 2019
@fregante
Drop outdated linkify-branch-refs
eb849e3 
#1985
@fregante fregante added help wanted small Issues that new contributors can pick up labels Apr 26, 2019
@sindresorhus
Copy link
Member

Perhaps the feature should just add a strike-through.

👍

@fregante
Copy link
Member Author

fregante commented Apr 26, 2019 •
edited

Ah, GitHub's own linkifier doesn't linkify the branch in the QuickPR page (#691), so maybe we should only limit the scope.

@fregante fregante changed the title Drop feature linkify-branch-refs Update feature linkify-branch-refs Apr 26, 2019
@jerone
Copy link
Contributor

jerone commented Jun 24, 2019

The feature linkify-branch-refs currently adds double links on PR:

image

@fregante fregante removed the cleanup label Jul 19, 2019
@fregante fregante mentioned this issue Jul 27, 2019
Closed
@rahgurung
Copy link
Contributor

rahgurung commented Jul 28, 2019 •
edited

@jerone So we have to remove unwanted one, right?

@rahgurung rahgurung mentioned this issue Jul 28, 2019
Closed
@fregante
Copy link
Member Author

fregante commented Jul 28, 2019 •
edited

This issue is to be solved in 3 parts:

  1. Avoid linkifying the branches on PRs: done in cb8de12
  2. Only add a strike through on deleted branches in PRs
  3. Keep linkifying “quick PR” pages: done in cb8de12

fregante added a commit that referenced this issue Jul 29, 2019
@fregante
Drop generic linkifier from linkify-branch-refs
cb8de12 
Closes #2275
Partial solution to #1985
@fregante
Copy link
Member Author

This is now mostly solved. I'm moving back to #2274 because it's more specific.

@fregante fregante mentioned this issue Apr 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted small Issues that new contributors can pick up
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jerone @sindresorhus @fregante @rahgurung