ci-link: hide duplicate status icon

[kidonng]

It seems that lately GitHub added a build status icon on the repo homepage and commit details page for repos using GitHub Actions. The latter is fine, while the former duplicates Refined GitHub's ci-link feature.
I think it's better to hide one of them, GitHub's one for consistency, or Refined GitHub's one for fewer HTTP requests/DOM manipulation (though I don't care about these expenses 😂).

Off topic

GitHub hurried this feature...

Example URL: https://github.com/zeit/now-builders

[yakov116]

@kidonng its only GitHub Actions so I dont think there is a need hide it at all

[kidonng]

It's to keep the interface neat, and I think this is easy to achieve (might just need to add a CSS rule).

[fregante]

I'm not seeing it, are you using an extension? Your style is different

[kidonng]

I'm using a user style written by myself 😀 I do have some other GitHub related extensions but I don't think they will add the icon.
I disabled Refined GitHub and found the icon still exists, without custom classes like rgh-xxx, so I believe it is from GitHub.

But now I'm not seeing it either, maybe GitHub is doing A/B testing. We can close this for now and wait for it to roll out to the public if you like.

Off topic

Just in case you might be interested, this is the icon on commit details page. Style from GitHub Dark. Of course I'm not seeing this now.

[yakov116]

@fregante checkout bootstrap

[fregante]

I disabled Refined GitHub and found the icon still exists, without custom classes like rgh-xxx, so I believe it is from GitHub.

rgh is Refined GitHub, I suppose you're talking about the icon still being after the repo title after you disable the extension. It's still there because you have to fully refresh the page to let the JavaScript unload

I like the 2 new positions you're showing me, they make sense and I hope to see them soon.

[kidonng]

rgh is Refined GitHub, I suppose you're talking about the icon still being after the repo title after you disable the extension. It's still there because you have to fully refresh the page to let the JavaScript unload

Of course I've refreshed 😄 I was saying that the icon looks ordinary thus it is from GitHub.

I like the 2 new positions you're showing me, they make sense and I hope to see them soon.

Me too, and hope they don't limit it to repos using GitHub Actions only.

[fregante]

I was saying that the icon looks ordinary thus it is from GitHub.

Sorry I misread 🤦‍♂️

[yakov116]

@fregante looks like they added it for all ci's!

[fregante]

I like their position and we should keep them there, but at the same time I also like to be able to see whether a project is failing from any page.

The only change I'd suggest here is to revert #1502 so our icon only ever points to the default branch

[kidonng]

Just wonder if we can add something like:

.rgh-repo-root .rgh-ci-link {
  display: none;
}

document.body.classList.toggle('rgh-repo-root', isRepoRoot())

😆 Guess this would get disapproved and I have to write user script myself

[busches]

@kidonng if you want to hide the icons added by RGH, you could disable the feature or use the existing class you listed.

.rgh-ci-link {
  display: none;
}

No need to add a new class or to add a user script, RGH supports overriding styles already.

[kidonng]

@busches I agree with what @fregante said:

At the same time I also like to be able to see whether a project is failing from any page.

From the beginning of this issue I'm not going to disable this useful feature 😁

[busches]

@kidonng sure and if you want to hide everything with .rgh-ci-link then you can do that, without needing an extra class on the body.

[kidonng]

Oh... to make it clear, I just want to hide one of the icons on repo's root, and the code above is just an example.

[fregante]

I just want to hide one of the icons on repo's root

It's not a terrible idea... but I think it's best to always show it there just not to break expectations.

[kidonng]

This seems more like a personal preference to me now... maybe I just got used to seeing both of them 🤣 closing this for the moment.

Just in case someone needs it, here's a quick solution with Stylus:

@-moz-document regexp("https://github.com/[^/]+/[^/]+$") {
  .rgh-ci-link {
    display: none;
  }
}