highlight-closing-prs-in-open-issues feature is now implemented by Github

[dotconnor]

This feature is now built into Github. Also with the update, the feature implemented by RGH is actually broken.

[yakov116]

Like our way much better!

[gabro]

FWIW, I would love to have a way to disable the one from GH and keep the one from refined-github, which is much easier to spot and way nicer to look at.

[kidonng]

Let's make it clear, GitHub has partly implemented RGH's two features: highlight-closing-prs-in-open-issues and extend-status-labels.

What GitHub provides:

• highlight-closing-prs-in-open-issues

While our lovely button links to the related commit, GitHub gives the closing PR.

But sometimes RGH will lose the game:

• extend-status-labels

Yeah, RGH's is much nicer.

[kidonng]

This feature is now built into Github. Also with the update, the feature implemented by RGH is actually broken.

Oh sorry didn't notice that, but I guess it's not completely broken. We need more cases.

[fregante]

GitHub has the advantage of being instant. We have to wait for the whole page to load before adding those links.

If GitHub shows ALL the possibly-closing PRs, we can drop our feature.

I think the style is a minor issue. Later we can discuss if it’s worth bringing GitHub’s information and display it like RGH does. At the moment it might just be a “I liked it the way it was before”

[gabro]

Later we can discuss if it’s worth bringing GitHub’s information and display it like RGH does.

That would also be nice.

My personal gripe with the way it's implemented in GitHub is the relative importance of that piece of info wrt the rest of the page. When I'm on an issue that has a linked PR, I care about that quite a lot and I frequently switch over, so, in that respect, the weight RGH gives to that info is quite good.

[fregante]

It doesn't seem to work consistently. Example sindresorhus/issue-regex#3

[fregante]

I'm removing these features since they are duplicate/non-working.

If anyone wants to improve GitHub's style, that would be a whole new feature with a new name anyway. Any related code can be found in the commits that closes this issue.

[yakov116]

@fregante I miss our way

[fregante]

Send a PR then