-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight TODO and FIXME. #2634
Comments
Can you elaborate more on how you imagine it would look? For example, would TODO comments be bolded or something. |
It could also be shown in #2579, e.g. "This PR adds 2 TODOs" but it would require a fetch of all the changes, which might be heavy (or heavy PRs could be excluded, if possible) |
Maybe also show |
Indeed, will change the title |
Note: I think eslint can automatically show this information inline as GitHub annotations. Example: Hopefully XO will soon too. xojs/xo#465 |
Too complex, plus that line is already super crowded and we had to disable a feature on it already. On the files tab, I think XO or eslint already takes care of that via GitHub Actions annotations. On the Conversation tab it would be useful to show this piece of information before the Mergeability box as suggested. I wonder if it’s useful to just show a compact list of GitHub annotations as a generic feature. |
Not sure what's actually the idea behind the project, but handling features via Github Actions (or any other CI application) would add some restrictions to the project. For instance, I don't use and don't intend to use Github Actions, such features wouldn't be accessible to me if it's handled this way. |
Indeed. Adding this piece of information is actually not too difficult on the Files tab since the content is already there; the problem is finding a way to place it other than inline/per-file like you showed in your mockup in December. Perhaps this feature can initially be just that since it doesn’t require any API calls. |
Tracked in #2579 |
Would be nice to have a way to easily find/see TODO and FIXME written in files.
i.e: See if a Pull Request stills contain new TODO/FIXME.
The text was updated successfully, but these errors were encountered: