Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Readme" text from repositories #3580

Closed
fregante opened this issue Sep 19, 2020 · 6 comments
Closed

Hide "Readme" text from repositories #3580

fregante opened this issue Sep 19, 2020 · 6 comments
Labels
enhancement help wanted small Issues that new contributors can pick up under discussion

Comments

@fregante
Copy link
Member

Does anyone have any idea of why this link exists on repo roots like https://github.com/sindresorhus/refined-github?

It points to the same page. Should we hide it? It can just be part of refined-github.css:

.BorderGrid-cell [href="#readme"] {
	display: none;
}
@notlmn
Copy link
Contributor

notlmn commented Sep 20, 2020

This is likely a feature they had for jumping to readme if repo root had a long list of files. Either that or it is put there to not leave "license" alone.

@fregante
Copy link
Member Author

Indeed. Then we should probably remove the feature that collapses the files since it accomplishes the same thing.

@fregante fregante added small Issues that new contributors can pick up help wanted labels Sep 21, 2020
@fregante

This comment has been minimized.

@fregante
Copy link
Member Author

Let's hide the link instead

@yakov116
Copy link
Member

@fregante should we just put in the css file of toggle-files-button? I was thinking that the reason we want it disabled is because of the feature.

@fregante
Copy link
Member Author

I was thinking that the reason we want it disabled is because of the feature.

Makes sense, let's not add conditional classes just yet though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up under discussion
Development

Successfully merging a pull request may close this issue.

3 participants