Avoid showing related issues when the issue title is empty #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grazie Marco! There's already a check in And if the suggestions remain faded if the search query is no longer long enough. It's fine this way as the search results are still useful to what the user previously typed. |
|
I guess the issue is actually about completely a empty field, rather than just "less than 3" |
fregante
changed the title
|
@bfred-it thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1267
This pull request fixes the issue where suggestions would be displayed with an empty title.
Now, the user must enter a minimum of 3 characters in order to generate suggestions. Also if the user clears the title field leaves less than 3 characters, the suggestion box is removed.