Shrink tab padding when 7+ tabs exist on Profile #1763
Conversation
source/content.css
Outdated
| @@ -1079,3 +1079,9 @@ body > .footer li a { | |||
| .dropdown-menu-sw { | |||
| transform-origin: 90% top; | |||
| } | |||
|
|
|||
| /* Fix wrapping text on tabs when gists tab is enabled on profile #1757 */ | |||
There was a problem hiding this comment.
This needs to mention the name of the gists tab feature
source/content.css
Outdated
|
|
||
| /* Fix wrapping text on tabs when gists tab is enabled on profile #1757 */ | ||
| nav.UnderlineNav-body a:nth-last-child(n+7).UnderlineNav-item, | ||
| nav.UnderlineNav-body a:nth-last-child(n+7).UnderlineNav-item ~ * { |
There was a problem hiding this comment.
You probably don’t need nav.UnderlineNav-body a in both. Use .UnderlineNav-item:nth-last-child(n+7)
There was a problem hiding this comment.
@sindresorhus is there a stylelint rule to enforce the order in compound selectors? e.g. .hello:nth-child(1) instead of :nth-child(1).hello
There was a problem hiding this comment.
I went with something specific as I wasn't sure everywhere this class was used, I can see it both ways.
There was a problem hiding this comment.
is there a stylelint rule to enforce the order in compound selectors? e.g.
.hello:nth-child(1)instead of:nth-child(1).hello
No, but you should request it. That would be a useful rule.
|
@ZYSzys I will hopefully get back to this tonight, if you want to finish it, you are more than welcome to. |
busches
force-pushed
the
tab-wrapping-on-profile
branch
2 times, most recently
from
ebfe2b9
to
e87bd97
Compare
|
This doesn't solve it for me. It still looks buggy:
I had to reduce it to |
|
@sindresorhus your profile looks fine on Windows 10 at 8px. Do you want me to make it 6px globally or detect OSX and make it 6px then? |
|
Make it 6px globally. System detection is a slippery slope. Maybe Linux needs 7px. And maybe the next Windows version changes the font so it now needs 6px too. |
Fixes #1757