Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New “Projects” tab messes up profile if “gists” tab enabled #1757

Closed
yeskunall opened this issue Feb 7, 2019 · 4 comments
Closed
Labels
bug enhancement help wanted small Issues that new contributors can pick up

Comments

@yeskunall
Copy link

GitHub added a new “Projects” tab. AFAICT, this wasn’t a thing couple of hours ago 🤨

Here’s what it looks like right now:

image

For now, my workaround is to simply disable the “gists” tab by adding profile-gists-link to my list of features to disable.

image

That fixes it, but I’m sure a lot of people appreciate quick access to their gists, so I’m opening an issue instead. 😅

@yeskunall
Copy link
Author

yeskunall commented Feb 7, 2019

Also, this is just a nit, but I remember the file name for the gist feature was something a lot more obvious. I had to make just a little bit of effort to find out which file holds the feature. 😁

I know disabling certain features is not officially supported by the extension, but if we’re going with consistent naming conventions, I would have expected it to be called something like show-gists-tab or something like that. 😅

@fregante
Copy link
Member

fregante commented Feb 8, 2019

The screenshot above doesn’t look broken.

We already have a feature that hides the project tab in repos, so we can extend that to also hide it in profiles

@jerone
Copy link
Contributor

jerone commented Feb 8, 2019

A little CSS fixes it:

.UnderlineNav-item {
    margin-right: 8px;
}

Then there is enough room for 17 numbers in the counters...

image

@fregante fregante added bug enhancement help wanted small Issues that new contributors can pick up labels Feb 9, 2019
@fregante
Copy link
Member

fregante commented Feb 9, 2019

@jerone that's good, we can also limit that to when there are 7+ tabs, with a quantity query: https://alistapart.com/article/quantity-queries-for-css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement help wanted small Issues that new contributors can pick up
Development

No branches or pull requests

3 participants