Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: disable features with a click in the options #1780

Merged
merged 34 commits into from May 28, 2019
Merged

Conversation

fregante
Copy link
Member

@fregante fregante commented Feb 14, 2019

Closes #2040

Screenshot 2019-05-19 at 18 30 14

Outdated notes

Notes:

  • I had initially had the link on the feature name, but a bunch of blue links looked tacky.
  • I thought we could handle this with an autocomplete-like feature, but with that we can't also link to the source (this would probably be solved if we had descriptions in each file)
  • about "checked means disabled": this is because the features are enabled by default, but to show them as "checked means enabled" we'd have to specify them all in the defaults in background.js.

    The form could be made more understandable by using colors, i.e. green on unchecked and red on checked boxes. Edit: I think the strikethrough is clear
options with list
screenshot of bdea47d (outdated)
options with list

@fregante fregante added the meta Related to Refined GitHub itself label Feb 14, 2019
@sindresorhus

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante fregante changed the title WIP: List all features List all features May 19, 2019
@fregante
Copy link
Member Author

Screenshot 2019-05-19 at 18 28 14

Also looks good in Firefox:

Screenshot 2019-05-19 at 18 30 14

@fregante
Copy link
Member Author

Moved description to second line, added screenshots field.

@fregante fregante requested a review from busches May 19, 2019 11:12
source/background.ts Outdated Show resolved Hide resolved
source/libs/features.tsx Outdated Show resolved Hide resolved
@fregante fregante changed the title List all features WIP: List all features May 19, 2019
`features` can't be imported in `options` and `background`, it will point to a different list from the one generated in `content`
….tsx

1. options depends on linkify-urls-in-code
2. linkify-urls-in-code was a feature file
3. the feature file depended features.tsx
4. features.tsx also tries to collect features
@fregante
Copy link
Member Author

fregante commented May 23, 2019

a way to quickly collapse the Feature list in options to easily get to the Custom CSS option.

We could move it to a tab, but I'd like to keep the options as "flat" as possible, also so we don't have to care much for their styles (given that it's shared between Chrome and Firefox)

You could also just move the custom CSS box above the feature list

Yeah, I like this better. I left the "logging" toggle below the list because it's more of a development feature anyway.

you could also add the descriptions as tooltips instead

Not tooltips because descriptions are long and sometimes include code, but I wouldn't mind moving the description behind an expand button. However I dislike having a long list of expandable micro information.

I'd hide the feature name too, but it gives users a handle to remember, discuss and find.

@simonkotwicz
Copy link
Contributor

simonkotwicz commented May 23, 2019

This is out of the scope for this PR but here are some other thoughts I had:

  • Group features in the same way they are grouped in the README (Declutter, More actions, etc.). However, this would require extra information to be added to each feature and maybe some feature don't fit in those categories.
  • Mark new features with a different colour or "NEW" tag (or bring them to the top of the list under a "New" heading) until the user clicks on the feature/source/screenshot.

@fregante
Copy link
Member Author

fregante commented May 25, 2019

I need to work on this further because the migrations aren't being triggered at times, I suspect it's because setTimeout in options-storage makes webext-options-sync call chrome.runtime.onInstalled too late.

I think the solution is to extract the features list at build time.

@fregante fregante self-assigned this May 25, 2019
source/options.tsx Outdated Show resolved Hide resolved
@fregante fregante changed the title List all 100 features Meta: disable features with a click in the options May 28, 2019
@fregante fregante merged commit 0ab4349 into master May 28, 2019
@fregante fregante deleted the options-for-humans branch May 28, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

List all the features in the settings
6 participants