New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: disable features with a click in the options #1780
Conversation
6fb79ad
to
bdea47d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`features` can't be imported in `options` and `background`, it will point to a different list from the one generated in `content`
….tsx 1. options depends on linkify-urls-in-code 2. linkify-urls-in-code was a feature file 3. the feature file depended features.tsx 4. features.tsx also tries to collect features
We could move it to a tab, but I'd like to keep the options as "flat" as possible, also so we don't have to care much for their styles (given that it's shared between Chrome and Firefox)
Yeah, I like this better. I left the "logging" toggle below the list because it's more of a development feature anyway.
Not tooltips because descriptions are long and sometimes include I'd hide the feature name too, but it gives users a handle to remember, discuss and find. |
This is out of the scope for this PR but here are some other thoughts I had:
|
I need to work on this further because the migrations aren't being triggered at times, I suspect it's because I think the solution is to extract the features list at build time. |
Closes #2040
Outdated notes
Notes:
about "checked means disabled": this is because the features are enabled by default, but to show them as "checked means enabled" we'd have to specify them all in thedefaults
inbackground.js
.The form could be made more understandable by using colors, i.e. green on unchecked and red on checked boxes.Edit: I think the strikethrough is clearscreenshot of bdea47d (outdated)