Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight own issues and PRs #1782

Merged
merged 9 commits into from
Feb 20, 2019
Merged

Highlight own issues and PRs #1782

merged 9 commits into from
Feb 20, 2019

Conversation

connorbrathwaite
Copy link
Contributor

@connorbrathwaite connorbrathwaite commented Feb 15, 2019

seems straightforward enough:

screen shot 2019-02-14 at 20 24 32

Fixes #1403

edit: forgot about issues, will amend soon!

@connorbrathwaite connorbrathwaite changed the title (feat): bold users pr author name WIP: (feat): Highlight issues or PRs that belong to the use Feb 15, 2019
@connorbrathwaite connorbrathwaite changed the title WIP: (feat): Highlight issues or PRs that belong to the use WIP: (feat): highlight issues or PRs that belong to the user Feb 15, 2019
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

source/features/highlight-user-prs.tsx Outdated Show resolved Hide resolved
source/content.ts Outdated Show resolved Hide resolved
source/features/highlight-user-prs.tsx Outdated Show resolved Hide resolved
source/features/highlight-user-prs.tsx Outdated Show resolved Hide resolved
features.add({
id: 'highlight-own-prs',
include: [
features.isPRList
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned we could also highlight our own issues, that’s a good idea. Maybe the name should then be highlight-own-issues-and-prs

@fregante fregante changed the title WIP: (feat): highlight issues or PRs that belong to the user Highlight own issues and PRs Feb 15, 2019
@sindresorhus
Copy link
Member

@connorbrathwaite Can you add the feature to the readme?

@fregante
Copy link
Member

Under the section “more info at a glance”

The title attribute always ends with the username [title$=], whereas the previous the previous [href*=] selector would match the username anywhere in the URL, even if incomplete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants