Enable reaction avatars for teams' discussions #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Dec 13, 2017
source/libs/page-detect.js
Outdated
| @@ -88,3 +88,5 @@ export const isSingleCommit = () => /^commit\/[0-9a-f]{5,40}/.test(getRepoPath() | |||
| export const isSingleFile = () => /^blob\//.test(getRepoPath()); | |||
|
|
|||
| export const isTrending = () => location.pathname.startsWith('/trending'); | |||
|
|
|||
| export const isDiscussion = () => /^([^/]+[/][^/]+\/)teams[/][^/]+[^/]+($|[/]$|[/]discussions)/.test(getCleanPathname()); | |||
fregante
reviewed
Dec 13, 2017
source/libs/page-detect.js
Outdated
| @@ -88,3 +88,5 @@ export const isSingleCommit = () => /^commit\/[0-9a-f]{5,40}/.test(getRepoPath() | |||
| export const isSingleFile = () => /^blob\//.test(getRepoPath()); | |||
|
|
|||
| export const isTrending = () => location.pathname.startsWith('/trending'); | |||
|
|
|||
| export const isDiscussion = () => /^([^/]+\/[^/]+\/)teams\/[^/]+[^/]+($|\/$|\/discussions)/.test(getCleanPathname()); | |||
There was a problem hiding this comment.
I think \/$| isn't necessary. getCleanPathname() never ends with a trailing slash.
|
🙈 of course! Will update the PR in a few. :)
…On Wed, Dec 13, 2017, 5:57 PM Federico Brigante ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In source/libs/page-detect.js
<#871 (comment)>
:
> @@ -88,3 +88,5 @@ export const isSingleCommit = () => /^commit\/[0-9a-f]{5,40}/.test(getRepoPath()
export const isSingleFile = () => /^blob\//.test(getRepoPath());
export const isTrending = () => location.pathname.startsWith('
/trending');
+
+export const isDiscussion = () => /^([^/]+\/[^/]+\/)teams\/[^/]+[^/]+($|\/$|\/discussions)/.test(getCleanPathname());
I think \/$| isn't necessary. getCleanPathname() never ends with a
trailing slash.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#871 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAuBrDEgAsqnP2MrXFLFLGv6xdyIKFqks5tAAIPgaJpZM4RAhkd>
.
|
|
@bfred-it thanks! |
|
Thanks @lukaszklis! |
|
@bfred-it A little offtopic question related to the changes requested in the PR: does it make sense to adjust linters to meet some of the requirements whenever people contribute to the repo? It might save maintainers’ priceless time on trivial topics. :) |
|
You mean custom rules? They'd be great, but then we'd have to also (know how to) code and debug them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out today the reaction avatars were not working for the recently launched ”Discussions” feature on GitHub. Unfortunately I do not have a live public example to link directly to test it, however I attach some screenshots before and after the change.
Before:
After:
