Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

820px is too narrow for global-nav container #86

Closed
kurtextrem opened this issue Mar 14, 2018 · 6 comments
Closed

820px is too narrow for global-nav container #86

kurtextrem opened this issue Mar 14, 2018 · 6 comments

Comments

@kurtextrem
Copy link
Contributor

I get this layout: http://prntscr.com/ir3a1h

It's because of

.global-nav .container {
	max-width: 820px !important;
}

920px would work.

Resolution: 1920x1080, in window: 1920x949

@larswittenberg
Copy link
Contributor

larswittenberg commented Mar 14, 2018

Same here.
880px an higher would work

@tata81
Copy link

tata81 commented Mar 16, 2018

Hi @kurtextrem @larswittenberg
I am a newbie to open source contribution, would like to work on this issue. But before that I have few questions

  1. Where to debug the current view and watch changes? like local copy ? Followed the exact steps which are mentioned in contribute section. The extension got added in the browser but couldn't figure out ? Can you help me please. Thanks

@larswittenberg
Copy link
Contributor

@tata81 have you run the build process and added die local extension (the /distribution folder) to your Browser? then reload the twitter.com Page and you can see your changes.

After making other changes, i toggle the local extension off and on, to trigger the update. But iam not sure, if this is the best way.

@filipekiss
Copy link
Contributor

Hey @tata81! Thank you for your interest in this issue.

To run a local copy, after you clone the exstension, you can run npm start and the build/watch process will begin. Then you can add the extension as described in the contribute section.

When you make a change, the script will rebuild the extension. After that, just point your Chrome to chrome://extensions and refresh the page and the extension will be reloaded and your changes will be applied (you need to also reload Twitter's tab).

@sindresorhus
Copy link
Owner

I've merged a workaround for this issue, but we should look into a proper fix:

A proper fix would be to use a better way to position the navbar elements, probably using Flexbox.

@sindresorhus
Copy link
Owner

Closing as this extension is now deprecated: 8dd9df7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants