Resolve directory to the real path before using as base for resolve #7
Conversation
index.js
Outdated
| @@ -11,7 +12,15 @@ const resolveFrom = (fromDir, moduleId, silent) => { | |||
| throw new TypeError(`Expected \`moduleId\` to be of type \`string\`, got \`${typeof moduleId}\``); | |||
| } | |||
|
|
|||
| fromDir = path.resolve(fromDir); | |||
| try { | |||
| fromDir = resolveLinkTarget.sync(fromDir); | |||
There was a problem hiding this comment.
Why not just fs.realpathSync()?
index.js
Outdated
| try { | ||
| fromDir = fs.realpathSync(fromDir); | ||
| } catch (err) { | ||
| if (err.code !== 'EINVAL') { |
There was a problem hiding this comment.
Not really sure why you're just throwing on EINVAL. Any error should be thrown.
You also have to correctly handle the silent argument. See line 32.
There was a problem hiding this comment.
you're right, EINVAL was needed only when used with the resolve-link-target lib. All should be thrown when using fs.realpathSync. Also added tests for silent.
Thanks for the quick review. If anything else, I'll fix tomorrow. morning.
There was a problem hiding this comment.
@sindresorhus, after thinking about this more, I am not so sure we have to throw any error. Right now it works if the fromDir does not exist in the filesystem. resolve seems to behave the same. So maybe we just need to use path.resolve on fromDir and then ignore ENOENT errors of realpathSync. What do you think?
|
LGTM 👍 |
sindresorhus
changed the title
|
Sorry, forgot about this. I'm gonna do a major bump just in case it affects something. |
Close #6