Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialize buffers #39

Merged
merged 7 commits into from
Jan 1, 2021
Merged

Don't serialize buffers #39

merged 7 commits into from
Jan 1, 2021

Conversation

OfryL
Copy link
Contributor

@OfryL OfryL commented Dec 8, 2020 •
edited by sindresorhus
Loading

Fixes #37

@OfryL
Update index.js
1fc49dc 
fix buffer handling
@sindresorhus
Copy link
Owner

This needs a test and it should also be documented how Buffer is handled.

@OfryL
Copy link
Contributor Author

OfryL commented Dec 21, 2020

@sindresorhus ping

sindresorhus
sindresorhus reviewed Dec 26, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Dec 26, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

You also need to update index.d.ts

@OfryL
Copy link
Contributor Author

OfryL commented Dec 27, 2020

@sindresorhus thanks

sindresorhus
sindresorhus reviewed Dec 28, 2020
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@OfryL
Copy link
Contributor Author

OfryL commented Dec 28, 2020

@sindresorhus fixed, i hope that's better

@sindresorhus sindresorhus changed the title Fix buffer handling Don't serialize buffers Jan 1, 2021
@sindresorhus sindresorhus merged commit d58ce16 into sindresorhus:master Jan 1, 2021
@vladimiry vladimiry mentioned this pull request Jan 23, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OutOfMemory exception on errors containing Buffers
2 participants
@OfryL @sindresorhus