AKS: fix the scroll coming when hovering over unicorn in nav-left #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevva
suggested changes
Sep 13, 2017
| @@ -73,6 +73,7 @@ a.nav-item:not(.button) | |||
| flex-basis: 0 | |||
|
|
|||
| .nav-left | |||
| overflow: hidden | |||
There was a problem hiding this comment.
@kevva I don't really order alphabetically. When I did CSS a lot before, I used to order layout type props first, and then visual only. I don't see any benefit in doing it alphabetically tbh.
|
@yabhis What browser and OS did you see this in? I haven't seen it before. Can you add the override to main.scss instead? I don't want to edit these files as they're bundled CSS framework files and should be updateable. |
|
@sindresorhus, I see this in Chrome 60.0.3112.113. Noticed you've fixed it now though :). |
|
@sindresorhus , I see this in Chrome Version 60.0.3112.113 (Official Build) (64-bit) |
bencwbrown
added a commit
to bencwbrown/bencwbrown.co.uk
that referenced
this pull request
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.