Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect dashes #31

Closed
paleite opened this issue May 3, 2019 · 5 comments · Fixed by #36
Closed

Incorrect dashes #31

paleite opened this issue May 3, 2019 · 5 comments · Fixed by #36

Comments

@paleite
Copy link

paleite commented May 3, 2019

slugify('XBOX360'); returns "xbo-x360". But I expected the value to be "xbox360"
@kainiedziela
Copy link

kainiedziela commented Jun 4, 2019 •
edited

You should pass a following options param: { decamelize: false }.

@TiagoDanin
Copy link
Contributor

image
https://runkit.com/tiagodanin/5cf6b2894117be001aa4a297 No problem here...

@paleite
Copy link
Author

paleite commented Jun 11, 2019

Thanks, but that’s not the same dependency.
This issue is about @sindresorhus/slugify: https://runkit.com/paleite/5cffe6e38b563f001ac2d5ea

@0x0480
Copy link

0x0480 commented Jul 3, 2019

Same issue with "3D" it returns 3-d lol

@notlmn
Copy link

notlmn commented Jul 3, 2019

As mentioned by @kainiedziela, use {decamelize: false}.

image

@TiagoDanin TiagoDanin mentioned this issue Jul 14, 2019
Merged
TiagoDanin added a commit to TiagoDanin-Forks/slugify that referenced this issue Feb 17, 2020
@TiagoDanin
Revert fix to incorrect dashes (sindresorhus#31)
f8d56b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate capitalized words TiagoDanin-Forks/slugify
5 participants
@paleite @TiagoDanin @kainiedziela @notlmn @0x0480